Open
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe these changes satisfy https://github.com/microsoft/VibeVoice/blob/c766f12e23ecb53113069398fbfcca6101abf88f/CONTRIBUTING.md#1-preferred-contributions
w.r.t. https://github.com/microsoft/VibeVoice/blob/c766f12e23ecb53113069398fbfcca6101abf88f/CONTRIBUTING.md#2-rejected-patterns, it's possible that one or two may fall under "Style Tweaks", but I'd hope they're all acceptable, and if not, I'm quite happy to drop any that aren't.
w.r.t. https://github.com/microsoft/VibeVoice/blob/c766f12e23ecb53113069398fbfcca6101abf88f/CONTRIBUTING.md#3-review-policy, these changes were not generated by an AI. Errors were identified by traditional heuristics and I applied corrections using simple search and replace / edits. (I did test tesseract-ocr on some images because I'm experimenting with it, but it didn't turn up anything.)