fix: add vLLM 0.16+ compatibility for multimodal processor APIs#291
Open
yubingjiaocn wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: add vLLM 0.16+ compatibility for multimodal processor APIs#291yubingjiaocn wants to merge 1 commit intomicrosoft:mainfrom
yubingjiaocn wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Move _get_data_parser from VibeVoiceMultiModalProcessor to VibeVoiceProcessingInfo.get_data_parser (required by vLLM >= 0.16) - Remove get_dummy_processor_inputs override to avoid ProcessorInputs signature mismatch (fixes vLLM >= 0.18 compatibility) - Add backward compat shim for vLLM < 0.16 via version detection - Add docs/vllm-version-compatibility.md documenting supported versions Fixes microsoft#259 Related: microsoft#231
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VibeVoice vLLM plugin fails on vLLM 0.16+ with two errors:
vLLM >= 0.16:
vLLM >= 0.18:
Changes
Three modifications to
vllm_plugin/model.py:Move
_get_data_parser→get_data_parser: The canonical data parser (setting target_sr=24kHz) now lives onVibeVoiceProcessingInfo.get_data_parser()instead ofVibeVoiceMultiModalProcessor._get_data_parser(), matching the vLLM 0.16 API.Remove
get_dummy_processor_inputsoverride: The custom override inVibeVoiceDummyInputsBuilderpassedmm_data=toProcessorInputs, which breaks on vLLM 0.18+ (expectsmm_data_items). The base class already handles both API versions correctly, so we rely on it while keeping ourget_dummy_text()andget_dummy_mm_data()methods.Add backward compat shim for vLLM < 0.16: At import time, we detect the vLLM version. For < 0.16, we monkey-patch
_get_data_parserontoVibeVoiceMultiModalProcessorso the same codebase works on 0.14.x.Additionally,
docs/vllm-version-compatibility.mddocuments supported vLLM versions and API changes.Backward Compatibility
_get_data_parseron the processor class.VibeVoiceProcessingInfo.get_data_parser()natively.ProcessorInputsconstruction correctly.Testing
Fixes #259
Related: #231