Catch Empty exception in streamer.py#293
Open
Chintanpatel24 wants to merge 1 commit intomicrosoft:mainfrom
Open
Catch Empty exception in streamer.py#293Chintanpatel24 wants to merge 1 commit intomicrosoft:mainfrom
Chintanpatel24 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Handle empty queue exception specifically instead of a general exception.
There was a problem hiding this comment.
Pull request overview
This PR tightens exception handling in the streaming iterator to only swallow the expected “queue empty” condition, improving debuggability and preventing unrelated errors from being silently ignored.
Changes:
- Import
EmptyfromqueuealongsideQueue. - Replace a bare
except:inAudioBatchIterator.__next__withexcept Empty:so only the empty-queue case is handled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle empty queue exception specifically instead of a general exception.