Skip to content

adjust code padding - #1490

Merged
Marcel W. (marcelwgn) merged 1 commit into
microsoft:mainfrom
Jay-o-Way:code-scrollviewer
Mar 29, 2024
Merged

Marcel W. (marcelwgn) merged 1 commit into
microsoft:mainfrom
Jay-o-Way:code-scrollviewer

Conversation

@Jay-o-Way

@Jay-o-Way Jay (Jay-o-Way) commented Mar 10, 2024 •

Copy link
Copy Markdown
Contributor

Description

Remove padding of UserControl and Grid, and set (bottom)margin on ContentPresenter.

Motivation and Context

fixes #1489, 1501

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

P.S. It's Styler that moved the VisualStateManager bits around

@karkarl

Copy link
Copy Markdown
Collaborator

/azp run

Comment thread WinUIGallery/Controls/ControlExample.xaml
Comment thread WinUIGallery/Controls/SampleCodePresenter.xaml
@marcelwgn

Copy link
Copy Markdown
Contributor

Thank you for fixing this Jay (@Jay-o-Way) , however please next time don't check in code formatting changes on that scale since it makes reviewing very difficult.

@marcelwgn
Marcel W. (marcelwgn) merged commit 49f21df into microsoft:main Mar 29, 2024
@Jay-o-Way
Jay (Jay-o-Way) deleted the code-scrollviewer branch March 29, 2024 16:45
Karen (karkarl) pushed a commit that referenced this pull request Jul 15, 2024
…ugh scrollbars (#1490)

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
Remove padding of UserControl and Grid, and set (bottom)margin on
ContentPresenter.

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
fixes #1489, ~1501~

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/d6aa1fed-1117-415d-8bb1-d8c7bd55bd46)

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

P.S. It's **Styler** that moved the **VisualStateManager** bits around
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants