Skip to content

Update samples to announce UI changes to narrator - #1509

Merged
Karen (karkarl) merged 1 commit into
microsoft:mainfrom
marcelwgn:dev/fix-missing-uia-announcements
Sep 24, 2024
Merged

Karen (karkarl) merged 1 commit into
microsoft:mainfrom
marcelwgn:dev/fix-missing-uia-announcements

Conversation

@marcelwgn

@marcelwgn Marcel W. (marcelwgn) commented Mar 19, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR adds UIA announcements to samples where they were missing. Also cleaning up unused function in XAMLUICommand page

Motivation and Context

Closes #169 and closes #334

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
Comment thread WinUIGallery/ControlPages/XamlUICommandPage.xaml Outdated
@karkarl

Copy link
Copy Markdown
Collaborator

/azp run

3 similar comments
@karkarl

Copy link
Copy Markdown
Collaborator

/azp run

@karkarl

Copy link
Copy Markdown
Collaborator

/azp run

@karkarl

Copy link
Copy Markdown
Collaborator

/azp run

@karkarl

Copy link
Copy Markdown
Collaborator

Can you try rebasing from main? Perhaps this will help with the failed tests

@marcelwgn
Marcel W. (marcelwgn) force-pushed the dev/fix-missing-uia-announcements branch from 30507ff to 52c64e5 Compare September 3, 2024 12:48
@karkarl

Copy link
Copy Markdown
Collaborator

/azp run

@karkarl
Karen (karkarl) merged commit 466107f into microsoft:main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants