Fix: A potential bug in Win32WindowHelper.cs - #1564
Merged
Merged
Conversation
Fix issue
Marcel W. (marcelwgn)
approved these changes
Jun 20, 2024
Marcel W. (marcelwgn)
left a comment
Marcel W. (marcelwgn)
left a comment
Contributor
There was a problem hiding this comment.
Very good catch, thank you for fixing this!
Collaborator
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the code to avoid potential problems(in 'WinUIGallery/Helper/Win32WindowHelper.cs')
Description
max may have been incorrectly written as min in the code
Motivation and Context
By analyzing the code, it can be inferred that there might be a problem here.
How Has This Been Tested?
Manual test
Screenshots (if appropriate):
Types of changes