Add a icon to the exe file - #1604
Merged
Merged
Conversation
Mgg Sk (MGGSK)
marked this pull request as ready for review
August 13, 2024 15:39
Collaborator
|
Thanks so much for the fix! |
Collaborator
|
/azp run |
Karen (karkarl)
approved these changes
Aug 27, 2024
Contributor
|
can you confirm if this solves #1512? |
Contributor
Author
That was already fixed before my pull request. |
|
TL;DR - this issue is live and needs to be re-opened. I can repo this by downloading WinUI-Gallary from the Store and observing a generic Windows App Icon not the ico in this pr. Here's images: I am troubleshooting why my WinUI3 App does not have a 16x16 Asset appearing when I have supplied all of the Visual Assets in the package.appxmanifest. It seems I'm not alone as the WinUi3 App has the same issue! 
I did try the code in this PR and it didn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a icon to the apps exe file.
Description
Set the exe icon in the project properties to "Assets\Tiles\GalleryIcon.ico"
Motivation and Context
Don't know why the exe doesn't have an icon.
Fixed this issue: #1600
How Has This Been Tested?
No testing needed.
Screenshots (if appropriate):
Types of changes