Skip to content

Fix: ColorPaletteResourcesPage theme toggle highlight - #1676

Merged
Niels Laute (niels9001) merged 1 commit into
microsoft:mainfrom
Zakariathr22:fix/colorpalette-theme-toggle
Dec 6, 2024
Merged

Niels Laute (niels9001) merged 1 commit into
microsoft:mainfrom
Zakariathr22:fix/colorpalette-theme-toggle

Conversation

@Zakariathr22

@Zakariathr22 Zakaria Tahri (Zakariathr22) commented Dec 5, 2024 •

Copy link
Copy Markdown
Contributor

Motivation and Context

Fixes #1674

How Has This Been Tested?

manually tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@Zakariathr22 Zakaria Tahri (Zakariathr22) changed the title Fix: ColorPaletteResourcesPage theme toggle highlight Dec 5, 2024

@marcelwgn Marcel W. (marcelwgn) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

Btw, if you include "Fixes #1671" in your PR, when this PR gets merged the issue referenced gets closed automatically! You can learn more about it here: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Comment thread WinUIGallery/ControlPages/ColorPaletteResourcesPage.xaml
@marcelwgn

Copy link
Copy Markdown
Contributor

/azp run

@niels9001 Niels Laute (niels9001) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! LGTM!

Comment thread WinUIGallery/ControlPages/ColorPaletteResourcesPage.xaml
@niels9001
Niels Laute (niels9001) merged commit c24f9da into microsoft:main Dec 6, 2024
@Zakariathr22
Zakaria Tahri (Zakariathr22) deleted the fix/colorpalette-theme-toggle branch December 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants