Skip to content

[UX] Pageheader improvements - #1679

Merged
Marcel W. (marcelwgn) merged 9 commits into
mainfrom
niels9001/improve-namespace-ux
Dec 12, 2024
Merged

[UX] Pageheader improvements#1679
Marcel W. (marcelwgn) merged 9 commits into
mainfrom
niels9001/improve-namespace-ux

Conversation

@niels9001

@niels9001 Niels Laute (niels9001) commented Dec 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

image

This PR moves the Namespace and Inheritance information in a flyout.

Closes #1678
@marcelwgn

Marcel W. (marcelwgn) commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

The button looks a bit off-center to me, it should probably be centered vertically to the main text run right?
marcelwgn
Marcel W. (marcelwgn) reviewed Dec 6, 2024
View reviewed changes
Comment thread WinUIGallery/ItemPage.xaml
@Jay-o-Way

Jay (Jay-o-Way) commented Dec 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

A number of these are empty. Would be pretty to hide the pop-up or better the button in this case.
@niels9001

Niels Laute (niels9001) commented Dec 6, 2024

Copy link
Copy Markdown
Collaborator Author

The button looks a bit off-center to me, it should probably be centered vertically to the main text run right?

Fixed it, it's now properly bottom aligned (text rendering and alignment is so much fun 😁)
@niels9001

Niels Laute (niels9001) commented Dec 6, 2024

Copy link
Copy Markdown
Collaborator Author

A number of these are empty. Would be pretty to hide the pop-up or better the button in this case.

Great catch! That's being handled now, so the i button no longer appears when there is no Namespace and BaseClasses
Jay-o-Way
Jay (Jay-o-Way) reviewed Dec 6, 2024
View reviewed changes
Comment thread WinUIGallery/Controls/PageHeader.xaml Outdated
Jay-o-Way
Jay (Jay-o-Way) reviewed Dec 6, 2024
View reviewed changes
Comment thread WinUIGallery/Controls/PageHeader.xaml Outdated
@niels9001 Niels Laute (niels9001) mentioned this pull request Dec 6, 2024
Merged
1 of 3 tasks
Jay-o-Way
Jay (Jay-o-Way) reviewed Dec 7, 2024
View reviewed changes
Comment thread WinUIGallery/Controls/PageHeader.xaml Outdated
Jay-o-Way
Jay (Jay-o-Way) reviewed Dec 7, 2024
View reviewed changes
Comment thread WinUIGallery/Controls/PageHeader.xaml Outdated
Niels Laute (niels9001) and others added 2 commits December 7, 2024 21:41
@niels9001 @Jay-o-Way
Update WinUIGallery/Controls/PageHeader.xaml
f31a21f 
Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
@niels9001
Margin tweak
8532ade
@niels9001

Niels Laute (niels9001) commented Dec 11, 2024

Copy link
Copy Markdown
Collaborator Author

/azp run
@marcelwgn

Marcel W. (marcelwgn) commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Is it just me or does the icon still look off center? 😅
Screenshot of header and offcenter button
@Jay-o-Way Jay (Jay-o-Way) mentioned this pull request Dec 11, 2024
Closed
1 of 4 tasks
@niels9001

Niels Laute (niels9001) commented Dec 12, 2024

Copy link
Copy Markdown
Collaborator Author

Is it just me or does the icon still look off center? 😅 Screenshot of header and offcenter button

Pushed a small change. Should be bottom-aligned now!

image
@marcelwgn

Marcel W. (marcelwgn) commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

/azp run
@marcelwgn
Marcel W. (marcelwgn) merged commit 77635ee into main Dec 12, 2024
@niels9001
Niels Laute (niels9001) deleted the niels9001/improve-namespace-ux branch February 5, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@niels9001 @marcelwgn @Jay-o-Way