Improved SystemBackdrop sample - #1698
Merged
Merged
Conversation
Mgg Sk (MGGSK)
marked this pull request as ready for review
December 23, 2024 20:32
Marcel W. (marcelwgn)
requested changes
Jan 12, 2025
Collaborator
|
Would it make sense to change this
We can also do this in a seperate PR! |
Niels Laute (niels9001)
requested changes
Jan 13, 2025
Niels Laute (niels9001)
requested changes
Jan 13, 2025
Collaborator
|
See a bunch of UX nits in my comments. The textblock is redundant if we use a ComboBox right? We can set the selected backdrop there, and increase the spacing between the 2 comboboxes a bit:
|
Contributor
Author
I changed the spacing from 12 to 20 px. |
Niels Laute (niels9001)
requested changes
Jan 14, 2025
Collaborator
|
/azp run |
1 similar comment
Contributor
|
/azp run |
Collaborator
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
Niels Laute (niels9001)
requested review from
Marcel W. (marcelwgn) and
Niels Laute (niels9001)
January 21, 2025 13:18
Niels Laute (niels9001)
approved these changes
Jan 21, 2025
Niels Laute (niels9001)
left a comment
Niels Laute (niels9001)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks!
Co-authored-by: Marcel W. <marcel.alex.wagner@outlook.com>
Co-authored-by: Marcel W. <marcel.alex.wagner@outlook.com>
Co-authored-by: Marcel W. <marcel.alex.wagner@outlook.com>
Contributor
|
Hi Mgg Sk (@MGGSK) |
Collaborator
|
/azp run |
Collaborator
|
Mgg Sk (@MGGSK) A few conflicts popped up because of the indention changed caused by #1700. Once those are resolved we can merge this in :) |
Marcel W. (marcelwgn)
approved these changes
Jan 28, 2025
Marcel W. (marcelwgn)
left a comment
Marcel W. (marcelwgn)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for updating these samples!
Contributor
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the sample easier to use.
Description
Motivation and Context
The old sample has no info about how the materials look like.
How Has This Been Tested?
Manual
Screenshots:
Types of changes