Skip to content

Reordering menu - #1758

Merged
Niels Laute (niels9001) merged 11 commits into
mainfrom
user/niels9001/menu-tweak
Feb 13, 2025
Merged

Niels Laute (niels9001) merged 11 commits into
mainfrom
user/niels9001/menu-tweak

Conversation

@niels9001

Copy link
Copy Markdown
Collaborator

Closes: #1542

New menu order:
image

@Jay-o-Way

Jay (Jay-o-Way) commented Feb 12, 2025 •

Copy link
Copy Markdown
Contributor

I would remove the separator line too. It makes it look like it separates all-of the-above from all-that-is-below, which doesn't match the menu. There's a small UX issue with that separator too: it does not move smoothly when expanding menus above it (like menu-items do) but jumps immediately.

@Jay-o-Way

Copy link
Copy Markdown
Contributor

Q: Do we need the "All samples" page at all?

Can't speak for everybody, but I never use it. The search function suffices for me.

@marcelwgn

Copy link
Copy Markdown
Contributor

I also think we can remove the separator but I would properly keep the pages. Its not causing any issues so I would keep it for now.

Comment thread WinUIGallery/Pages/NavigationRootPage.xaml Outdated
@niels9001

Copy link
Copy Markdown
Collaborator Author

Removed the separator 👍

@niels9001

Copy link
Copy Markdown
Collaborator Author

/azp run

@Jay-o-Way

Copy link
Copy Markdown
Contributor

Let's update <x:String x:Key="ControlsName">All samples</x:String> in App.xaml too

@niels9001

Copy link
Copy Markdown
Collaborator Author

/azp run

@marcelwgn

Copy link
Copy Markdown
Contributor

/azp run

@marcelwgn

Copy link
Copy Markdown
Contributor

/azp run

@niels9001
Niels Laute (niels9001) merged commit 69b4263 into main Feb 13, 2025
@niels9001
Niels Laute (niels9001) deleted the user/niels9001/menu-tweak branch February 13, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants