Refactor: Simplify AppWindow sample windows logic - #1834
Merged
Niels Laute (niels9001) merged 5 commits intoApr 16, 2025
Merged
Niels Laute (niels9001) merged 5 commits into
Niels Laute (niels9001) merged 5 commits into
Conversation
Zakaria Tahri (Zakariathr22)
marked this pull request as draft
April 15, 2025 17:01
Zakaria Tahri (Zakariathr22)
marked this pull request as ready for review
April 15, 2025 17:43
…he centered position in the `CenterWindow` method.
Niels Laute (niels9001)
approved these changes
Apr 16, 2025
Niels Laute (niels9001)
enabled auto-merge (squash)
April 16, 2025 15:26
This reverts commit 4c37b44.
Collaborator
|
/azp run |
Zakaria Tahri (Zakariathr22)
deleted the
simplify-appwindow-sample-windows
branch
April 16, 2025 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the
AppWindowsample windows logic by removing unnecessary code and making additional changes to improve readability and maintainability.How Has This Been Tested?
Manually tested
Types of changes