add border to icon - #1856
Merged
Niels Laute (niels9001) merged 9 commits intoMay 6, 2025
Merged
add border to icon#1856
Conversation
Niels Laute (niels9001)
requested changes
Apr 27, 2025
Jay (Jay-o-Way)
force-pushed
the
background-for-icon
branch
from
April 27, 2025 13:38
00a8d8b to
1c4719c
Compare
Contributor
|
Out of topic: |
Niels Laute (niels9001)
self-requested a review
May 5, 2025 08:24
Niels Laute (niels9001)
requested changes
May 5, 2025
Niels Laute (niels9001)
left a comment
Niels Laute (niels9001)
left a comment
Collaborator
There was a problem hiding this comment.
Jay (@Jay-o-Way) Please add the rounded corners (and optional padding to overcome to corner issue) as proposed by the design team, then we can get this in.
Thanks!
Contributor
Author
|
Niels Laute (@niels9001) Why don't you just finish it for me. Since we can't seem to agree on anything. Just do it your way. |
Niels Laute (niels9001)
self-requested a review
May 5, 2025 10:33
Niels Laute (niels9001)
approved these changes
May 5, 2025
Niels Laute (niels9001)
enabled auto-merge (squash)
May 5, 2025 10:34
Jay (Jay-o-Way)
commented
May 5, 2025
Collaborator
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a border and background to the larger icon in the SidePanel.
Closes #1854
Motivation and Context
Clarity. This shows how any "overlay icons" are placed inside the available area. May help finding the right icon.
Screenshots (if appropriate):
Types of changes