Tag icon entries using "symbol-icon" for Symbol enum categorization

[Andrew KeepCoding (AndrewKeepCoding)]

Description

This PR updates the IconsData.json file by tagging icon entries that belong to the Symbol enum. This change complements issue #1880 and aligns with PR #1881.

Motivation and Context

This makes easier to see the options when using SymbolIcon.

How Has This Been Tested?

Ran the app and confirmed the changes.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[Niels Laute (niels9001)]

/azp run

[Marcel W. (marcelwgn)]

So it looks like some of the icons we have are not named like the enum or they do not exist at all in the enum. Below is what missmatches we have with matching for enum via name or code point:

Settings, isSymbol: False, symbolTag: True // Different name
Search, isSymbol: False, symbolTag: True // ???
PageSolid, isSymbol: False, symbolTag: True // ???
FavoriteStar, isSymbol: False, symbolTag: True // Possible favorite?
FavoriteStarFill, isSymbol: False, symbolTag: True // Possible favorite?
FullScreen, isSymbol: True, symbolTag: False // Exists, missing tag
KeyboardClassic, isSymbol: False, symbolTag: True // Keyboard
Unpin, isSymbol: False, symbolTag: True // Different name
Slideshow, isSymbol: False, symbolTag: True // Different name
SetlockScreen, isSymbol: False, symbolTag: True // Different name
MapPin2, isSymbol: False, symbolTag: True // Does not exist
CC, isSymbol: False, symbolTag: True // ???
Recent, isSymbol: False, symbolTag: True // ???
MailFill, isSymbol: False, symbolTag: True // Different name
Webcam, isSymbol: False, symbolTag: True // Different name
Picture, isSymbol: False, symbolTag: True // Different name
Characters, isSymbol: False, symbolTag: True // Different name
GotoToday, isSymbol: False, symbolTag: True // Different name
Unfavorite, isSymbol: False, symbolTag: True // Different name
Reshare, isSymbol: False, symbolTag: True // Different name
UnsyncFolder, isSymbol: False, symbolTag: True // Different name
BulletedList, isSymbol: False, symbolTag: True // Different name
Accounts, isSymbol: False, symbolTag: True // Different name

Andrew KeepCoding (@AndrewKeepCoding) What was the rule for when you added the symbol-icon tag? Also we need to think about the impact of the name being different than the value in the enum and the possible confusion

Code for ref:

var stSymbol = icon.Name;
var hasSymbol = Enum.IsDefined(typeof(Symbol), (Symbol)Convert.ToUInt32(icon.Code, 16)) || icon.SymbolName != null;
var hasSymbolTag = icon.Tags.Contains("symbol-icon");
if(hasSymbol != hasSymbolTag)
{
    Debug.WriteLine($"{icon.Name}, isSymbol: {hasSymbol}, symbolTag: {hasSymbolTag}");
}

[Andrew KeepCoding (AndrewKeepCoding)]

Marcel W. (@marcelwgn)

What was the rule for when you added the symbol-icon tag?

I just extracted the codes from the Summary comment on each Symbol enum item. Then added the "symbol-icon" tag to each corresponding icon entry in IconsData.json. With a little help from ChatGPT of course.

Also we need to think about the impact of the name being different than the value in the enum and the possible confusion

Yeah, this is mentioned in #1880. I can fix that in the PR for #1972.

[Marcel W. (marcelwgn)]

Also we need to think about the impact of the name being different than the value in the enum and the possible confusion

Yeah, this is mentioned in #1880. I can fix that in the PR for #1972.

Sure lets fix that in your pr for #1972, thank you for working on this!

[Marcel W. (marcelwgn)]

/azp run