Skip to content

Fix accessibility: Add proper AutomationProperties.Name to Sound page buttons - #1982

Merged
Niels Laute (niels9001) merged 3 commits into
mainfrom
copilot/fix-1968
Jul 30, 2025
Merged

Niels Laute (niels9001) merged 3 commits into
mainfrom
copilot/fix-1968

Conversation

Copilot AI commented Jul 30, 2025 •

Copy link
Copy Markdown
Contributor

The buttons under "Play Specific System Sound" heading were announcing inappropriate names to screen readers. When users navigated to these buttons, Narrator was announcing "Right pointing black triangle shape, Focus, button" instead of the expected "Focus, button".

Root Cause

The buttons used Unicode triangle character (▶) in their Content property:

<Button Content="&#x25B6; Focus" Tag="0" />

Screen readers interpret this Unicode character as "Right pointing black triangle shape", which creates a poor user experience for visually impaired users.

Solution

Added AutomationProperties.Name to each of the 7 buttons with clean, descriptive names:

<Button 
    Content="&#x25B6; Focus" 
    Tag="0" 
    AutomationProperties.Name="Focus" />

This change ensures that:

  • Screen readers announce clean button names (e.g., "Focus, button")
  • Visual appearance remains unchanged for sighted users (triangle symbol still visible)
  • All button functionality is preserved

Impact

  • Accessibility: Major improvement for users relying on screen readers
  • Visual: No change - buttons look exactly the same
  • Functional: No change - all button click handlers work identically
  • Compliance: Meets MAS 4.2.1 – Object Information requirements

The fix affects all 7 sound control buttons: Focus, Invoke, Show, Hide, MovePrevious, MoveNext, and GoBack.

Fixes #1968.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • e7bvsblobprodcus348.vsblob.vsassets.io
    • Triggering command: dotnet build WinUIGallery.sln (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…buttons

Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Copilot AI changed the title [WIP] [WinUI 3 Gallery: Media-> Sound]: Inappropriate button name is announced by the narrator for the buttons present under "Play Specific System Sound" heading. Jul 30, 2025
@niels9001

Copy link
Copy Markdown
Collaborator

Tested, the right name is announced

@niels9001
Niels Laute (niels9001) marked this pull request as ready for review July 30, 2025 13:15
@niels9001
Niels Laute (niels9001) enabled auto-merge (squash) July 30, 2025 13:15
@niels9001

Copy link
Copy Markdown
Collaborator

/azp run

@niels9001
Niels Laute (niels9001) merged commit 713c7cf into main Jul 30, 2025
@niels9001
Niels Laute (niels9001) deleted the copilot/fix-1968 branch July 30, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants