Skip to content

Fix accessibility: Associate Tags label with TagsItemsView for screen readers - #2004

Merged
Niels Laute (niels9001) merged 5 commits into
mainfrom
copilot/fix-1966
Aug 6, 2025
Merged

Niels Laute (niels9001) merged 5 commits into
mainfrom
copilot/fix-1966

Conversation

Copilot AI commented Jul 31, 2025 •

Copy link
Copy Markdown
Contributor

This PR fixes an accessibility issue in the Iconography page where the "Tags" label was not properly associated with the list of tag items for screen readers.

Problem

When using screen readers like Narrator, users navigating to the tag items in the Iconography page would only hear the individual tag names without any context about the group they belong to. This violated WCAG 1.3.1 - Info and Relationships and created confusion for users with visual impairments.

Solution

Added proper AutomationProperties to establish the label-control relationship:

<TextBlock
    x:Name="TagsLabel"
    Text="Tags" />
<ItemsView
    x:Name="TagsItemsView"
    AutomationProperties.LabeledBy="{x:Bind TagsLabel}"
    ItemsSource="{x:Bind SelectedItem.Tags, Mode=OneWay}">

Technical Details

  • Minimal change: Only 2 lines added to the existing XAML
  • Follows existing patterns: Uses the same approach as AccessibilityScreenReaderPage.xaml
  • No visual impact: Pure accessibility improvement with no changes to UI appearance or functionality
  • Screen reader improvement: Narrator will now announce "Tags" when entering/exiting the group of tag items

Testing

The fix follows established accessibility patterns in the codebase and addresses the specific MAS 1.3.1 compliance requirement mentioned in the issue.

Fixes #1966.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • e7bvsblobprodcus348.vsblob.vsassets.io
    • Triggering command: dotnet restore WinUIGallery.sln (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Copilot AI changed the title [WIP] [WinUI 3 Gallery: Fundamentals-> Custom &user controls]: Group name "Tags" is not associated with the menu list items present under it. Jul 31, 2025
@niels9001
Niels Laute (niels9001) marked this pull request as ready for review July 31, 2025 08:14

@niels9001 Niels Laute (niels9001) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well!

@marcelwgn

Copy link
Copy Markdown
Contributor

/azp run

@niels9001
Niels Laute (niels9001) merged commit 16acdaf into main Aug 6, 2025
@niels9001
Niels Laute (niels9001) deleted the copilot/fix-1966 branch August 6, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants