Fix tree-item appearance comment - #36770
Draft
Jon Ludwig (jcludwig) wants to merge 2 commits into
Draft
Jon Ludwig (jcludwig) wants to merge 2 commits into
Jon Ludwig (jcludwig) wants to merge 2 commits into
Conversation
Updated the comment to reflect the correct property description.
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Accordion 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Accordion. - RTL.normal.chromium.png | 21803 | Changed |
| vr-tests-web-components/Accordion.Disabled.normal.chromium.png | 6687 | Changed |
| vr-tests-web-components/Accordion. - RTL.normal.chromium_1.png | 6715 | Changed |
| vr-tests-web-components/Accordion.Marker Position End.normal.chromium.png | 6016 | Changed |
| vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png | 2466 | Changed |
| vr-tests-web-components/Accordion.Size.normal.chromium.png | 21729 | Changed |
| vr-tests-web-components/Accordion. - Dark Mode.normal.chromium.png | 5954 | Changed |
vr-tests-web-components/Button 10 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Button.Outline Disabled.default.chromium.png | 131 | Changed |
| vr-tests-web-components/Button.Outline Disabled.pressed.chromium.png | 160 | Changed |
| vr-tests-web-components/Button.Primary Disabled.hover.chromium.png | 1793 | Changed |
| vr-tests-web-components/Button.Primary Disabled.pressed.chromium.png | 2117 | Changed |
| vr-tests-web-components/Button.Subtle Disabled.default.chromium.png | 98 | Changed |
| vr-tests-web-components/Button.Subtle Disabled.pressed.chromium.png | 404 | Changed |
| vr-tests-web-components/Button.Subtle Disabled.hover.chromium.png | 114 | Changed |
| vr-tests-web-components/Button.Transparent Disabled.default.chromium.png | 165 | Changed |
| vr-tests-web-components/Button.Transparent Disabled.hover.chromium.png | 119 | Changed |
| vr-tests-web-components/Button.Transparent Disabled.pressed.chromium.png | 133 | Changed |
vr-tests-web-components/Divider 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Divider.Inset.normal.chromium.png | 2 | Changed |
vr-tests-web-components/Label 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Label. - Dark Mode.normal.chromium_1.png | 171 | Changed |
| vr-tests-web-components/Label. - RTL.normal.chromium.png | 7 | Changed |
| vr-tests-web-components/Label.Disabled.normal.chromium.png | 116 | Changed |
| vr-tests-web-components/Label.Required.normal.chromium.png | 7 | Changed |
vr-tests-web-components/MenuList 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
| vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png | 498 | Changed |
| vr-tests-web-components/MenuList. - RTL.1st selected.chromium_2.png | 39384 | Changed |
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium_3.png | 38816 | Changed |
vr-tests-web-components/RadioGroup 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png | 89 | Changed |
| vr-tests-web-components/RadioGroup.Disabled.2nd selected.chromium.png | 125 | Changed |
vr-tests-web-components/Slider 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Slider. - Dark Mode.normal.chromium_1.png | 177 | Changed |
| vr-tests-web-components/Slider.Disabled.normal.chromium.png | 223 | Changed |
| vr-tests-web-components/Slider. - Dark Mode.rightArrow.chromium_2.png | 242 | Changed |
| vr-tests-web-components/Slider.Disabled.rightArrow.chromium.png | 287 | Changed |
vr-tests-web-components/Text 9 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Text.Italic.normal.chromium.png | 155 | Changed |
| vr-tests-web-components/Text.Truncate.normal.chromium.png | 5819 | Changed |
| vr-tests-web-components/Text.Underline.normal.chromium.png | 265 | Changed |
| vr-tests-web-components/Text.Font.normal.chromium.png | 6452 | Changed |
| vr-tests-web-components/Text.Strikethrough.normal.chromium.png | 209 | Changed |
| vr-tests-web-components/Text.Block.normal.chromium.png | 6296 | Changed |
| vr-tests-web-components/Text.Nowrap.normal.chromium.png | 6094 | Changed |
| vr-tests-web-components/Text.Weight.normal.chromium.png | 12958 | Changed |
| vr-tests-web-components/Text.Size.normal.chromium.png | 70284 | Changed |
vr-tests-web-components/TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/TextInput.Disabled.normal.chromium.png | 198 | Changed |
There were 6 duplicate changes discarded. Check the build logs for more information.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Code comment (and therefore also CEM) incorrectly mentions "size" for the tree-item appearance attribute.
New Behavior
Corrected the comment to refer to "appearance".
Related Issue(s)