fix(web-components): compact empty vertical dividers - #36796
Open
Cody Sorgenfrey (codysorgenfrey) wants to merge 2 commits into
Open
Cody Sorgenfrey (codysorgenfrey) wants to merge 2 commits into
Cody Sorgenfrey (codysorgenfrey) wants to merge 2 commits into
Conversation
Treat whitespace-only default slots as empty while retaining contentful divider sizing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Cody Sorgenfrey (codysorgenfrey)
requested a review
from a team
as a code owner
September 24, 2026 20:27
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:empty, which does not match whitespace-only light DOM.Fixes #31623
Validation
YARN_NPM_REGISTRY_SERVER=https://packagefeedproxy.microsoft.io/npm/).nx run web-components:type-checkandnx run web-components:lintpassed (lint has 97 existing warnings).nx run web-components:e2e -- --grep Dividerpassed: Chromium CSR/SSR 22/22 and WebKit CSR/SSR 22/22.nx run web-components:check:ssrverified the divider outputs but reports three pre-existing stale templates elsewhere:textarea,text-input, andfield.