Skip to content

fix(web-components): compact empty vertical dividers - #36796

Open
Cody Sorgenfrey (codysorgenfrey) wants to merge 2 commits into
microsoft:masterfrom
codysorgenfrey:codysorgenfrey-vertical-divider-empty-height
Open

Cody Sorgenfrey (codysorgenfrey) wants to merge 2 commits into
microsoft:masterfrom
codysorgenfrey:codysorgenfrey-vertical-divider-empty-height

Conversation

@codysorgenfrey

@codysorgenfrey Cody Sorgenfrey (codysorgenfrey) commented Sep 24, 2026 •

Copy link
Copy Markdown

Summary

  • Track meaningful default-slot content rather than relying on :empty, which does not match whitespace-only light DOM.
  • Apply the 20px compact minimum to empty vertical dividers while retaining the 84px contentful minimum and inset/alignment styling.
  • Add Playwright regression coverage for empty, whitespace/comment-only, contentful, and dynamically changing slots; update CSR/SSR styles, templates, generated API documentation, and the patch change file.

Fixes #31623

Validation

  • Immutable Yarn install succeeded through the Microsoft npm proxy (YARN_NPM_REGISTRY_SERVER=https://packagefeedproxy.microsoft.io/npm/).
  • nx run web-components:type-check and nx run web-components:lint passed (lint has 97 existing warnings).
  • Focused nx run web-components:e2e -- --grep Divider passed: Chromium CSR/SSR 22/22 and WebKit CSR/SSR 22/22.
  • nx run web-components:check:ssr verified the divider outputs but reports three pre-existing stale templates elsewhere: textarea, text-input, and field.
  • Firefox browser runs stalled at startup on this host and could not be completed.
Treat whitespace-only default slots as empty while retaining contentful divider sizing.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant