fix(react-utilities): handle special native prop names - #36806
Open
Paolo Aliprandi (paolo-aliprandi) wants to merge 3 commits into
Open
Paolo Aliprandi (paolo-aliprandi) wants to merge 3 commits into
Paolo Aliprandi (paolo-aliprandi) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Paolo Aliprandi (paolo-aliprandi)
marked this pull request as ready for review
September 29, 2026 13:57
Paolo Aliprandi (paolo-aliprandi)
requested review from
a team
as code owners
September 29, 2026 13:57
Paolo Aliprandi (paolo-aliprandi)
requested a review
from Victor Genaev (mainframev)
September 29, 2026 15:31
| ): TAttributes { | ||
| const allowedPropNames = (tagName && nativeElementMap[tagName]) || htmlElementProperties; | ||
| const allowedPropNames = | ||
| tagName && Object.prototype.hasOwnProperty.call(nativeElementMap, tagName) |
Contributor
There was a problem hiding this comment.
we could use the https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn
Suggested change
| tagName && Object.prototype.hasOwnProperty.call(nativeElementMap, tagName) | |
| tagName && Object.hasOwn(nativeElementMap, tagName) |
Contributor
Author
There was a problem hiding this comment.
I tried this suggestion, but react-utilities:build fails with error TS2550 because this package’s configured TypeScript lib does not include Object.hasOwn. I kept Object.prototype.hasOwnProperty.call, which provides the same own-property check and preserves the current build target. Do you think it's ok to proceed in this way?
Contributor
There was a problem hiding this comment.
Martin Hochel (@Hotell) do you think we can tweak ts config to allow using Object.hasOwn?
| for (const key of keys) { | ||
| const isNativeProp = | ||
| (!isArray && (allowedPropNames as Record<string, number>)[key]) || | ||
| (!isArray && Object.prototype.hasOwnProperty.call(allowedPropNames, key)) || |
Contributor
There was a problem hiding this comment.
same here
Contributor
Author
There was a problem hiding this comment.
as above
Copilot started reviewing on behalf of
Dmytro Kirpa (dmytrokirpa)
September 29, 2026 19:48
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fixes have regression coverage, and no unresolved issues were identified.
Review effort: Balanced
Findings: None
What changed in this PR
This PR fixes how react-utilities filters native props with special property names, preventing prototype-chain matches and preserving the filtered result’s prototype.
Changes:
- Require own-property matches for native element and prop allow-lists.
- Safely copy an explicitly allowed
__proto__property. - Add regression tests and a patch change file.
| File | Description |
|---|---|
packages/react-components/react-utilities/src/utils/properties.ts |
Tightens allow-list matching and safely copies __proto__. |
packages/react-components/react-utilities/src/utils/properties.test.ts |
Tests inherited names and result-prototype behavior. |
packages/react-components/react-utilities/src/utils/getNativeElementProps.ts |
Avoids inherited tag-name matches. |
packages/react-components/react-utilities/src/utils/getNativeElementProps.test.ts |
Tests a prototype-chain tag name. |
change/@fluentui-react-utilities-98768ced-77df-4ff0-942d-db5a851f8745.json |
Records the patch release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Paolo Aliprandi (paolo-aliprandi)
requested review from
Dmytro Kirpa (dmytrokirpa)
and
a balanced review from Copilot
October 1, 2026 09:34
Copilot started reviewing on behalf of
Paolo Aliprandi (paolo-aliprandi)
October 1, 2026 09:35
View session
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
yarn nx run react-utilities:test --runTestsByPath src/utils/getNativeElementProps.test.ts src/utils/properties.test.ts --runInBandyarn nx run react-utilities:lintyarn nx run react-utilities:build