feat(react-timepicker-preview): add time utilities - #36812
Draft
Victor Genaev (mainframev) wants to merge 1 commit into
Draft
Victor Genaev (mainframev) wants to merge 1 commit into
Victor Genaev (mainframev) wants to merge 1 commit into
Conversation
Victor Genaev (mainframev)
added this pull request to stack #36815
September 30, 2026 11:00
This was referenced Sep 30, 2026
Ports the time math from react-timepicker-compat (option generation, anchors, formatting and parsing of time strings) together with its tests. The types that were internal in compat (`Hour`, `TimeFormatOptions`, `TimePickerOption`, `TimeStringValidationResult`) move to `utils/types.ts` so they can be exported with the component.
Victor Genaev (mainframev)
force-pushed
the
timepicker-preview/time-utils
branch
from
September 30, 2026 11:03
8d8509a to
9858197
Compare
|
Pull request demo site: URL |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #36811 scaffold → #36812 time utilities → #36813 TimePicker → #36814 headless TimePicker
New Behavior
Ports the time math from react-timepicker-compat into
src/utilstogether with its tests: option generation, start/end anchors, formatting, and parsing/validation of time strings.Types that were internal in compat (
Hour,TimeFormatOptions,TimePickerOption,TimeStringValidationResult,TimePickerErrorType) move toutils/types.ts. They become public together with the component in #36813