Merged
Conversation
mjcheetham
approved these changes
Nov 17, 2020
derrickstolee
approved these changes
Nov 17, 2020
Just like we did in git/git in cac42e471afa (ci: avoid using the deprecated `set-env` construct, 2020-11-07), we use the recommended alternative described in the `set-env` deprecation announcement in https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
dont-use-set-env-in-ci
branch
from
b0b85fa to
bd225b3
Compare
Member
Author
|
Yay PowerShell! |
Just like `set-env`, we need to avoid using `add-path`. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
dont-use-set-env-in-ci
branch
from
479d8af to
c215cad
Compare
derrickstolee
approved these changes
Nov 17, 2020
derrickstolee
added a commit
that referenced
this pull request
Dec 9, 2020
This updates on top of the 20.10.178 release. Requires build updates from #466. This actually updates to a better build: 1. It has a new tag `v2.29.0.vfs.0.1`. 2. It was created after `git-for-windows/build-extra` updated with the new GCM Core package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This imitates git/git@cac42e471afa to avoid using the now-deprecated
set-envconstruct in our CI workflow.