Config fix#39
Open
agoryuno wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've rewritten the
torchscale.architecture.configmodule to use inheritance and remove the redundant code. There are now 3 classes:Config- that holds all common optionsEncoderConfig- inherits 'Config' and holds Encoder specific optionsDecoderConfig- inherits 'Config' and holds Decoder specific optionsEncoderDecoderConfig- inheritsEncoderConfigandDecoderConfigand holds that one option shared by Encoder and Decoder objects.I also took the liberty to add some type hints for
argsparameters in encoder/decoder modules.