[fmt] Update to 12.2.0 [many ports] Fix compatibility with fmt 12.2.0#52423
Conversation
3116ef2 to
0de3675
Compare
32e37c0 to
32c381c
Compare
|
Rather than all these patches, would it be easier to just create the fmt/core.h file in the fmt port which then includes fmt/format.h? |
NO, I don't think patching the fmt port to make
If vcpkg changes At the same time, I also submitted a PR to the affected upstream repo—not to intentionally complicate matters, but because we really should do this. |
Sorry, my suggestion was based on the assumption that
Yes, thanks for doing this. |
|
FYI, we just pushed a new release (v0.3.0) of hareflow containing the fixes. ref |
|
@blavallee Thank you, I will update this pr as soon as the ci finish. |
|
The following error occured I just baseline it. |
|
This pr is stable now, and ready for review. |
BillyONeal
left a comment
There was a problem hiding this comment.
This resulted in a bit of a SNAFU with the reviewing tools resulting in #52485
Several of the patches have incorrect CRLF line endings rather than LF line endings. We can't ban all CRLFs in patches because patched sources that themselves contain CRLFs will have CRLFs.
However, this is a green build and a huge update to an important library and I don't want to reset build over what is morally a style change. I'll just say in future to try to double check that produced patch files are LF. git diff --output blah will do the right thing, git diff > blah on PowerShell will not.
|
All these works are done on a mac, if a patch file contains CRLF, then the source file itself must have CRLF, how should we deal with this situation? |
I just try to make sure all patches are made by (As for making the review tool no longer angry, that's why I did #52485 ) |
./vcpkg x-add-version --alland committing the result.Update to 12.2.0
fmt 12.2.0 introdue a change that break some downstream ports.
fmtlib/fmt@0007426
https://dev.azure.com/vcpkg/public/_build/results?buildId=133287
Related PR: