Skip to content

Add eslint.codeActionsOnSave.options#1999

Merged
dbaeumer merged 5 commits into
microsoft:mainfrom
MariaSolOs:on-save
May 6, 2025
Merged

Add eslint.codeActionsOnSave.options#1999
dbaeumer merged 5 commits into
microsoft:mainfrom
MariaSolOs:on-save

Conversation

@MariaSolOs

Copy link
Copy Markdown
Contributor

Continues the work from #1945

@dbaeumer dbaeumer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things

Comment thread server/src/eslintServer.ts Outdated
@MariaSolOs

Copy link
Copy Markdown
Contributor Author

Only minor things

@dbaeumer I addressed your final formatting comments. Let me know if you have further feedback! :)

@dbaeumer

Copy link
Copy Markdown
Member

Will do. Busy with other stuff this week.

@MariaSolOs

Copy link
Copy Markdown
Contributor Author

@dbaeumer Could you please take another look of this PR? :)

@dbaeumer

dbaeumer commented May 6, 2025

Copy link
Copy Markdown
Member

Sorry was on vacation the last two weeks.

@vs-code-engineering vs-code-engineering Bot added this to the May 2025 milestone May 6, 2025
@dbaeumer dbaeumer merged commit 6f8769b into microsoft:main May 6, 2025
@MariaSolOs MariaSolOs deleted the on-save branch May 6, 2025 16:43
@MariaSolOs

Copy link
Copy Markdown
Contributor Author

Sorry was on vacation the last two weeks.

No worries. Hope you had a nice break!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants