chore: rename color var for comment input box#197950
Merged
alexr00 merged 2 commits intomicrosoft:mainfrom Nov 13, 2023
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
d-mahard
force-pushed
the
chore/comment-box-var-rename
branch
from
9646f53 to
8c0618c
Compare
also change the default color to inherit from input.background
d-mahard
force-pushed
the
chore/comment-box-var-rename
branch
from
8c0618c to
5da11da
Compare
alexr00
approved these changes
Nov 13, 2023
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thanks for the PR! After seeing how inputBackground looks, I think it is too big of a color difference. I've changed it back to use peekViewTitleBackground. The rename is still good though, and I've updated the css to also use the color when the input box is expanded.
hediet
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #196584
Follow-up from #197738
Changes:
@alexr00