Skip to content

treeStickyScroll change default value to boolean#198849

Merged
benibenj merged 2 commits intomicrosoft:mainfrom
abhijit-chikane:tree_sticky_scroll_config_fix
Nov 22, 2023
Merged

treeStickyScroll change default value to boolean#198849
benibenj merged 2 commits intomicrosoft:mainfrom
abhijit-chikane:tree_sticky_scroll_config_fix

Conversation

@abhijit-chikane
Copy link
Contributor

@abhijit-chikane abhijit-chikane commented Nov 22, 2023

treeStickyScroll change default value from string to boolean
@alexr00 alexr00 assigned benibenj and unassigned alexr00 Nov 22, 2023
@benibenj
Copy link
Contributor

benibenj commented Nov 22, 2023

Thanks for reporting and fixing this. However, I changed the default to be true for it to be tested during the next couple of days and will turn it off again before releasing it to stable.
@benibenj benibenj self-requested a review November 22, 2023 17:15
@vscodenpa vscodenpa added this to the November 2023 milestone Nov 22, 2023
@benibenj benibenj enabled auto-merge November 22, 2023 17:47
@abhijit-chikane
Copy link
Contributor Author

abhijit-chikane commented Nov 22, 2023 •
edited
Loading

Thanks for reporting and fixing this. However, I changed the default to be true for it to be tested during the next couple of days and will turn it off again before releasing it to stable.

Sure, well I have already got one
#198865
@benibenj benibenj merged commit a5bd17e into microsoft:main Nov 22, 2023
@abhijit-chikane abhijit-chikane deleted the tree_sticky_scroll_config_fix branch November 23, 2023 01:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants

@abhijit-chikane @benibenj @rzhao271 @alexr00 @vscodenpa