TerminalTaskSystem: Add support for nushell#238440
Merged
Merged
Conversation
so that it won't fallback to have extra "/d /c" arguments added
dylanchu
force-pushed
the
nushell_support
branch
from
a390ce6 to
0ea7ee5
Compare
Contributor
Author
|
I'm wandering if we can have the "executable to additional arguments" conf in settings.json. Then vscode can try to fetch the arguments from it or fallback to the default arguments specified by another key-value field instead of the hard coded "/d /c". But I'm not an expert on vscode dev, maybe someone can help to implement this later (if it's resonable). |
|
Looking forward to the merge @meganrogge |
meganrogge
approved these changes
May 9, 2025
amunger
approved these changes
May 9, 2025
meganrogge
approved these changes
May 13, 2025
TylerLeonhardt
approved these changes
May 13, 2025
auto-merge was automatically disabled
May 23, 2025 16:08
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that it won't fallback to have extra "/d /c" arguments added
Since this commit was reverted, this should be a safe fix for nushell to work just out of the box with
vscode.ShellExecution. And this should fix #169821 for nushell.