Disassembly View: don't display invalid memory instructions#249779
Merged
connor4312 merged 1 commit intoMay 28, 2025
Merged
Conversation
eronnen
changed the title
eronnen
changed the title
connor4312
approved these changes
May 28, 2025
aeschli
approved these changes
May 28, 2025
Contributor
|
Should VSCode also ignore instructions that are explicitly marked "invalid" in the presentation hint returned by the debug adapter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore instructions returned by the debug adapter that have invalid memory (-1).
This can happen when VSCode tries to disassemble unmapped memory, for example, when scrolling past a module address range.
Fix #249782