disasembly view: handle negative line height returned by debug adapter#250081
Merged
connor4312 merged 1 commit intoMay 31, 2025
Merged
Conversation
eronnen
force-pushed
the
disassembly-handle-negative-line-height
branch
from
e264059 to
8bf09e4
Compare
connor4312
approved these changes
May 31, 2025
roblourens
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle gracefully instructions returned by the debug adapter with
endLinesmaller thanline, OtherwisegetHeightcan return a negative number which can mess up the view.Fixes #250174. After the fix:
Screencast.From.2025-05-31.09-07-14.webm