Reinstate symbol icon colors in quickpicks (fix #299650)

[gjsjohnmurray]

This PR fixes #299650

[Copilot]

Pull request overview

This PR addresses issue #299650 by restoring symbol-kind icon colors in quick pick UIs (e.g., “Go to Symbol”) by opting rendered codicon markup into the workbench’s symbol color styling.

Changes:

• Extend renderLabelWithIcons / renderIcon to optionally add the codicon-colored CSS class.
• Update HighlightedLabel to render embedded icons with codicon-colored enabled when supportIcons is true.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
src/vs/base/browser/ui/iconLabel/iconLabels.ts	Adds an opt-in flag to append codicon-colored to rendered icon spans.
src/vs/base/browser/ui/highlightedlabel/highlightedLabel.ts	Enables colored icon rendering for icon markup rendered via HighlightedLabel.

[mrleemurray]

@gjsjohnmurray looks good - please add some tests to cover the new behaviour & I will re-test :)

[alythobani]

Hi! FYI I think #299479 is a directly related issue to this as well.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[gjsjohnmurray]

@gjsjohnmurray looks good - please add some tests to cover the new behaviour & I will re-test :)

@mrleemurray test added, please review.

[gjsjohnmurray]

Please can this be milestoned for 1.116.0?

[gjsjohnmurray]

Please can this be milestoned for 1.116.0?

Or 1.117.0?

[gjsjohnmurray]

@mrleemurray can I do anything to help progress this?

[gjsjohnmurray]

@mrleemurray another nudge

[gjsjohnmurray]

Thanks both. Please merge.