Kill and restart esbuild instances during watch mode#321219
Merged
Merged
Conversation
Reduces memory usage since we don't need rebuilds all that often. Perf still is reasonable in for the full rebuild
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the shared extension esbuild watch runner to avoid retaining an esbuild build context during watch mode, instead performing a full esbuild.build() per file-change and stopping the esbuild service after builds to reduce memory usage.
Changes:
- Replace persistent
esbuild.context(...).rebuild()usage with fullesbuild.build(...)per watch-triggered rebuild. - Call
esbuild.stop()after non-watch builds (and after each watch-triggered build) to release the esbuild service/resources.
Show a summary per file
| File | Description |
|---|---|
| extensions/esbuild-common.mts | Switch watch-mode rebuild strategy to full builds per change and stop esbuild services after builds to reduce memory use. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
56
to
74
| let debounce: ReturnType<typeof setTimeout> | undefined; | ||
| const rebuild = () => { | ||
| if (debounce) { | ||
| clearTimeout(debounce); | ||
| } | ||
| debounce = setTimeout(async () => { | ||
| try { | ||
| await ctx.cancel(); | ||
| const result = await ctx.rebuild(); | ||
| // Also instead of retaining the esbuild context, we are re-running the entire build on each change. | ||
| // This reduces memory usage since most projects don't need to be re-built often. | ||
| const result = await esbuild.build(options); | ||
| if (result.errors.length === 0) { | ||
| await didBuild?.(); | ||
| } | ||
| } catch (error) { | ||
| console.error('[watch] build error:', error); | ||
| } finally { | ||
| esbuild.stop(); | ||
| } | ||
| }, 100); |
alexdima
previously approved these changes
Jun 12, 2026
aeschli
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces memory usage since we don't need rebuilds all that often. Perf still is reasonable in for the full rebuild