Skip to content

Revert "Improve the local to native and remote to local copy, paste, and DND experience (#320685)"#323490

Merged
lramos15 merged 1 commit into
mainfrom
lramos15/dirty-orangutan
Jun 29, 2026
Merged

Revert "Improve the local to native and remote to local copy, paste, and DND experience (#320685)"#323490
lramos15 merged 1 commit into
mainfrom
lramos15/dirty-orangutan

Conversation

@lramos15

Copy link
Copy Markdown
Member

This reverts commit f9070ac.

Copilot AI review requested due to automatic review settings June 29, 2026 13:31
@lramos15 lramos15 enabled auto-merge (squash) June 29, 2026 13:31
@lramos15 lramos15 self-assigned this Jun 29, 2026
@lramos15 lramos15 added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Jun 29, 2026
@vs-code-engineering

Copy link
Copy Markdown
Contributor

This PR will be automatically cherry-picked to release/1.127 when merged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reverts the earlier changes that enhanced local-to-native and remote-to-local copy/paste and drag-and-drop behavior in the desktop workbench, restoring the prior clipboard/DND and remote file access behavior.

Changes:

  • Revert native clipboard integration for file resources (back to VS Code’s custom code/file-list clipboard buffer only).
  • Remove the remote file system proxy infrastructure (main/renderer pieces + tests) that enabled cross-window access to remote providers.
  • Revert remote-to-local clipboard temp download logic in Explorer copy/cut flows and simplify DND text transfer behavior.
Show a summary per file
File Description
src/vs/workbench/services/clipboard/electron-browser/clipboardService.ts Reverts platform-native file clipboard formats and returns to a single VS Code custom clipboard buffer format for resources.
src/vs/workbench/electron-browser/desktop.main.ts Removes registration of the remote file system proxy server/client in the renderer.
src/vs/workbench/contrib/files/browser/explorerService.ts Removes remote clipboard temp-download logic and writes original resources directly to the clipboard service.
src/vs/workbench/browser/dnd.ts Reverts the filtering behavior for text drag data (restores prior behavior of setting text from all file-service resources).
src/vs/platform/files/test/electron-main/remoteFileSystemProxy.test.ts Removes tests for the remote file system proxy main handler.
src/vs/platform/files/electron-main/remoteFileSystemProxyMainHandler.ts Removes the main-process proxy router implementation.
src/vs/platform/files/electron-browser/remoteFileSystemProxyServer.ts Removes the renderer-side server channel exposing file operations to other windows.
src/vs/platform/files/electron-browser/remoteFileSystemProxyClient.ts Removes the renderer-side proxy provider used by windows without a direct remote connection.
src/vs/platform/files/common/remoteFileSystemProxy.ts Removes the shared IPC channel name constants for the proxy feature.
src/vs/code/electron-main/app.ts Removes the main-process channel registration for the remote file system proxy handler.

Review details

  • Files reviewed: 10/10 changed files
  • Comments generated: 0
  • Review effort level: Low
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@deepak1556

Matched files:

  • src/vs/code/electron-main/app.ts
@lramos15 lramos15 merged commit 26d3646 into main Jun 29, 2026
30 checks passed
@lramos15 lramos15 deleted the lramos15/dirty-orangutan branch June 29, 2026 14:29
@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Jun 29, 2026
@vs-code-engineering vs-code-engineering Bot added this to the 1.126.0 milestone Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-cherry-pick Automated cherry-pick between release and main branches

3 participants