fix(e2e): preserve host node_modules + expose report port in docker #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
ochafik
force-pushed
the
ochafik/docker-node-modules
branch
from
0fbc825 to
3a0a8e2
Compare
ochafik
changed the title
- Move node_modules aside before Docker to avoid host/container binary conflicts - Restore after Docker completes - Expose port 9323 and serve report on 0.0.0.0 on test failure
ochafik
force-pushed
the
ochafik/docker-node-modules
branch
from
3a0a8e2 to
415ce6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running
npm run test:e2e:docker:updateon macOS (or any non-Linux host), the Docker container runsnpm ciwhich installs Linux-native binaries (e.g.,sharp). These overwrite the host'snode_modules, causing issues when running local commands afterwards.Solution
mv node_modules{,.local} && docker run -p 9323:9323 ... && rm -fR node_modules && mv node_modules{.local,}