fix(qr-server): remove deprecated FastMCP constructor args #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python SDK (modelcontextprotocol/python-sdk#1898) moved transport-specific parameters (port, stateless_http) from FastMCP constructor to run(). This broke the qr-server when run via stdio. The port is already passed directly to uvicorn.run() for HTTP mode, so these constructor args were redundant.
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
ochafik
reviewed
Jan 20, 2026
| @@ -27,7 +27,7 @@ | |||
| HOST = os.environ.get("HOST", "0.0.0.0") # 0.0.0.0 for Docker compatibility | |||
| PORT = int(os.environ.get("PORT", "3108")) | |||
Contributor
There was a problem hiding this comment.
can this be removed? does FastMCP use PORT / HOST and/or FASTMCP_PORT / FASTMCP_HOST?
ochafik
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python SDK (modelcontextprotocol/python-sdk#1898) moved transport-specific parameters (
port,stateless_http) fromFastMCPconstructor torun(). This broke the qr-server when run via stdio.The port is already passed directly to
uvicorn.run()for HTTP mode, so these constructor args were redundant.