fix: propagate stdio process exit during initialization#960
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
DragonFSKY
force-pushed
the
fix/959-stdio-process-exit
branch
from
a121041 to
a1c7e0f
Compare
Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
fix/959-stdio-process-exit
branch
from
a1c7e0f to
1c7a13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialize.Fixes #959
Notes
This keeps the scope limited to process exits that happen after
ProcessBuilder.start()succeeds and before initialization completes. It does not change startup failures or normal stdio shutdown behavior.A stdio-specific
McpStdioServerProcessExitExceptionis used so this initialization fast-fail path does not apply to generic transport exceptions from other transports.Test Plan
./mvnw -pl mcp-core,mcp-test spring-javaformat:apply./mvnw -pl mcp-core test./mvnw -pl mcp-test -am test -Dtest=StdioMcpClientInitializationFailureTests -Dsurefire.failIfNoSpecifiedTests=false./mvnw -pl mcp-test -am test -Dtest=HttpClientStreamableHttpAsyncClientResiliencyTests#testPing -Dsurefire.failIfNoSpecifiedTests=false./mvnw clean test(local run reachedmcp-testand failed in HTTP/Testcontainers resiliency/security integration tests; I did not count the full suite as passing)