wallet: enhance multisig file handling and API#10267
Open
catduck101 wants to merge 5 commits intomonero-project:masterfrom
Open
wallet: enhance multisig file handling and API#10267catduck101 wants to merge 5 commits intomonero-project:masterfrom
catduck101 wants to merge 5 commits intomonero-project:masterfrom
Conversation
iamamyth
reviewed
Dec 31, 2025
iamamyth
reviewed
Dec 31, 2025
iamamyth
reviewed
Dec 31, 2025
|
It looks to me like the comments on the original PR weren't addressed, and I've effectively just repeated them. Stopping review. |
iamamyth
reviewed
Jan 1, 2026
iamamyth
reviewed
Jan 1, 2026
iamamyth
reviewed
Jan 1, 2026
|
One other broad note on this PR: Given the existence and relative priority of the wallet2/wallet_api refactor PRs, this PR will likely remain in the queue for a long time. I think it makes sense to drop PEM support and then just let this stay dormant for a while, as I doubt there'll be many available or interested reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing and updating #7357 - for reference, that PR added methods to the wallet API for exporting and importing partially signed key images as well as methods for loading and signing multisig transactions from the filename. The development of it basically stalled.
PEM_read_string's return value to a booleanexportMultisigImagesPEMandexportMultisigImagesToFilefor exports andimportMultisigImagesFromFileandimportMultisigImagesFromPEMfor multisig image imports. Removed old unclear functions for importing and exporting imagesdest_addressesrenamed todestAddressesin order to be consistent with the camelCase inpending_transaction.cppand zero copyingexportMultisigImagesPEM.PendingTransactionImplmemory leak inloadMultisigTxFromFile