Prevent overriding of '#define INLINE'#484
Closed
vortigont wants to merge 1 commit intomoononournation:masterfrom
Closed
Prevent overriding of '#define INLINE'#484vortigont wants to merge 1 commit intomoononournation:masterfrom
vortigont wants to merge 1 commit intomoononournation:masterfrom
Conversation
'#define INLINE' is used frequently in other libs, unprotected override results in tons on compiler warnings like this: `warning: "INLINE" redefined`
Owner
|
That does not fully fix the conflict, is it better if rename it to e.g. GFX_INLINE? |
Contributor
Author
|
yes, it's not there to fix the conflict but, probably user could use same definition in different libs, but it's could turn into unexpected result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'#define INLINE' is used frequently in other libs, unprotected override results in tons on compiler warnings like this:
warning: "INLINE" redefinedThis PR will protect it with
#ifndefguard and prevent warnings in case globalINLINEis defined