Skip to content

Add importable $closeModal helper #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2024
Merged

Add importable $closeModal helper #1088

merged 1 commit into from
Oct 27, 2024

Conversation

MrSnoozles
Copy link
Contributor

No description provided.

rigor789
rigor789 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make this more robust with provide/inject, but for the time being I think this solution will work fine too (we'll have to see in practice, in case it breaks in some cases).

Thanks for implementing this!
@rigor789 rigor789 merged commit 04199a5 into nativescript-vue:main Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@MrSnoozles @rigor789