feat(files): include favorite state in unified search results#58980
feat(files): include favorite state in unified search results#58980tobiasKaminsky wants to merge 3 commits into
Conversation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
|
This is c&p from CollectionPhoto.php:76 |
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
|
Make some adjustments per review comments/etc on @tobiasKaminsky's behalf. ;-) Separate from this PR’s changes: I noticed |
Thanks for helping out :) I blindly c&p another approach within server, so there might be meanwhile something better, yes. |
| $fileQuery = $this->buildSearchQuery($query, $user); | ||
| $results = $userFolder->search($fileQuery); | ||
|
|
||
| $fileIds = array_map(static fn (Node $result): string => $result->getId(), $results); |
There was a problem hiding this comment.
Internal Server Error\nOCA\Files\Search\FilesSearchProvider::OCA\Files\Search\{closure}(): Return value must be of type string, int returned in file '/home/nickv/Nextcloud/34/server/apps/files/lib/Search/FilesSearchProvider.php' line 111
There was a problem hiding this comment.
Highlighted by psalm and CS
but shows we also don't have a unit test nor integration test covering this.
6 participants
Summary
favoriteattribute to file unified-search resultsChecklist
3. to review, feature component)stable32)AI (if applicable)