Skip to content

Update workflows#286

Merged
lcobucci merged 2 commits intonikic:masterfrom
codemasher:update-workflows
Jun 18, 2025
Merged

Update workflows#286
lcobucci merged 2 commits intonikic:masterfrom
codemasher:update-workflows

Conversation

@codemasher
Copy link
Copy Markdown
Contributor

Hey,

this PR updates the workflow runs to use the latest versions of actions/checkout and ramsey/composer-install to stop the node.js deprecation warnings.

Further I have moved the PHPUnit cache directory under .build/.phpunit.cache (now looking at it, the leading . is a bit unnecessary) and cleaned up the .gitignore.

Cheers!

@lcobucci
Copy link
Copy Markdown
Collaborator

Thanks for the patch.

What's the benefit in changing the phpunit cache location to you?

@codemasher
Copy link
Copy Markdown
Contributor Author

codemasher commented Apr 23, 2024

This is a standard practice in all my projects

  • no random unrelated directories in the project root, the other (temporary) PHPUnit output paths (coverage, logs) are already in .build
  • easy to .gitignore anything not project related
  • only have to exclude only a single directory in the IDE (other than vendor)

Actually, we could do the same with the .phpbench directory, but i haven't looked at where it is created, nor ran it locally yet.

@lcobucci lcobucci self-assigned this Jun 18, 2025
@lcobucci lcobucci added the CI label Jun 18, 2025
@lcobucci lcobucci added this to the 2.0.0-beta2 milestone Jun 18, 2025
@lcobucci
Copy link
Copy Markdown
Collaborator

@codemasher I've rebased this branch on top of the latest changes, keeping only the changes that make sense to me.

Thank you for contributing!

@lcobucci lcobucci merged commit 1c96139 into nikic:master Jun 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants