test: demonstrate API key filtering bug with multiple clients#1
Closed
test: demonstrate API key filtering bug with multiple clients#1
Conversation
This test demonstrates the bug where API key secrets with multiple client IDs are incorrectly filtered, keeping only the first client ID alphabetically. Expected: All client IDs (client1, client2, client3) should be preserved Actual: Only client1 is preserved, client2 and client3 are dropped Related to envoyproxy#8227
This test would fail with the current implementation because client2 is dropped from the cache (only client1, the first alphabetically, is preserved). The existing E2E tests only tested client1, which is why the bug went undetected. This test demonstrates that authentication with client2 fails due to the filtering bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates Bug
This PR contains failing tests that prove the API key secret filtering bug exists.
What fails:
client1is preserved,client2andclient3are droppedkey2(client2) failsRoot cause:
The
expectedAndFirstFallbackFilterkeeps only predefined keys + first key alphabetically. API key secrets use arbitrary client IDs as keys, so all except the first are dropped.Related:
This PR is for demonstration only. See the fix branch for the solution.