Skip to content

test: move core saving and loading into common.js#167

Merged
joyeecheung merged 3 commits into
nodejs:masterfrom
joyeecheung:refactor-test
Feb 14, 2018
Merged

test: move core saving and loading into common.js#167
joyeecheung merged 3 commits into
nodejs:masterfrom
joyeecheung:refactor-test

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Feb 4, 2018

Copy link
Copy Markdown
Member

This was used by #147 to reuse the code that generates a core dump and saves it for testing, but it's worth getting merged first.

cc @cjihrig @bnoordhuis
cjihrig

This comment was marked as off-topic.

Sign in to view

@joyeecheung

joyeecheung commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

@cjihrig Thanks for the review. Updated, PTAL.
bnoordhuis

This comment was marked as off-topic.

Sign in to view

@joyeecheung

joyeecheung commented Feb 11, 2018

Copy link
Copy Markdown
Member Author

@bnoordhuis I think target delete is no longer necessary now that we kill the process after saving the core...updated, PTAL, thanks!
cjihrig

This comment was marked as off-topic.

Sign in to view

@joyeecheung joyeecheung merged commit a3b9032 into nodejs:master Feb 14, 2018
@joyeecheung joyeecheung mentioned this pull request Mar 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@joyeecheung @bnoordhuis @cjihrig