doc: update collaborator guide to match the project size#296
Conversation
|
cc @nodejs/llnode and @nodejs/diagnostics |
|
If this turns out to be a bad idea we can always go back to the previous policy later. |
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 79.23% 79.23%
=======================================
Files 33 33
Lines 4229 4229
=======================================
Hits 3351 3351
Misses 878 878Continue to review full report at Codecov.
|
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
I'm OK with trying this if no one else objects.
|
I wonder do we even need two approvals here? As far as I know most projects in this organization don't have this kind of requirement, and mostly operate on 1-apporval-whenever. The two-approval requirement was also just introduced recently to Node.js. |
|
I'm open to 1-apporval-whenever if others are. |
This commits modifies our collaborator guide to match the current project size. llnode is way smaller than nodejs/node, and requiring two approvals to land a change/one approval with a seven day wait can be quite bureaucratic. Two approvals represent 50% of our active reviewers at the moment, which is quite a lot. Changing the requirements to one approval with no wait time once a PR gets approved makes more sense for this project, and it also matches other smaller projects across the organization.
mmarchini
force-pushed
the
changes-in-collaborator-guide
branch
from
65f52b7 to
1ddc1e2
Compare
|
Updated COLLABORATORS_GUIDE with 1-apporval-whenever. Please let me know what y'all think :) |
This commits modifies our collaborator guide to match the current project size. llnode is way smaller than nodejs/node, and requiring two approvals to land a change/one approval with a seven day wait can be quite bureaucratic. Two approvals represent 50% of our active reviewers at the moment, which is quite a lot. Changing the requirements to one approval with no wait time once a PR gets approved makes more sense for this project, and it also matches other smaller projects across the organization. PR-URL: #296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in afaec48 |
5 participants
This commits modifies our collaborator guide to match the current
project size. llnode is way smaller than nodejs/node, and requiring two
approvals to land a change/one approval with a seven day wait can be
quite bureaucratic. Two approvals represent 50% of our active reviewers
at the moment, which is quite a lot. Changing the requirements to one
approval with no wait time once a PR gets approved makes more sense for
this project, and it also matches other smaller projects across the
organization.