Skip to content

Why do we include both *-inl.h and *.h in the same .cc file? #16519

Closed
Closed
Why do we include both *-inl.h and *.h in the same .cc file?#16519
Labels
c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.questionIssues asking questions about Node.js.

Description

@joyeecheung
joyeecheung
opened on Oct 26, 2017
  • Version: master
  • Subsystem: src

Just noticed this when doing #16122, clang-format has a different idea of alphabetical orders and put -inl.h includes before .h includes. Is there a reason that we include them both? Usually including -inl.h is enough because they should include .h as well, and they should be self-contained.

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.questionIssues asking questions about Node.js.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions