Skip to content

test: changed fixtures require - #15899

Closed
creisle wants to merge 1 commit into
nodejs:masterfrom
creisle:code-and-learn/test-require-cache-without-stat
Closed

test: changed fixtures require#15899
creisle wants to merge 1 commit into
nodejs:masterfrom
creisle:code-and-learn/test-require-cache-without-stat

Conversation

@creisle

@creisle creisle commented Oct 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

changed common.fixturesDir to use common.fixtures
also removed unnecessary assignment of require('common') to variable

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@creisle
test: changed fixtures require
ad965bc 
changed common.fixturesDir to use common.fixtures
also removed unnecessary assignment of require('common') to variable
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 6, 2017
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeAR BridgeAR self-assigned this Oct 9, 2017
BridgeAR pushed a commit that referenced this pull request Oct 9, 2017
@creisle @BridgeAR
test: changed fixtures require
4a1359f 
PR-URL: #15899
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Oct 9, 2017

Copy link
Copy Markdown
Member

Landed in 4a1359f

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !
@BridgeAR BridgeAR closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@creisle @MylesBorins
test: changed fixtures require
dba620b 
PR-URL: #15899
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@creisle @addaleax
test: changed fixtures require
1dad272 
PR-URL: nodejs/node#15899
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@creisle @MylesBorins
test: changed fixtures require
eee7d52 
PR-URL: #15899
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@creisle @MylesBorins
test: changed fixtures require
4c6ba92 
PR-URL: #15899
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@creisle @MylesBorins
test: changed fixtures require
683e48c 
PR-URL: #15899
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. module Issues and PRs related to the module subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

7 participants

@creisle @BridgeAR @watilde @mscdex @MylesBorins @Trott @nodejs-github-bot