Skip to content

test: use common.fixtures module in test-preload.js - #15975

Closed
lzcabrera wants to merge 1 commit into
nodejs:masterfrom
lzcabrera:test-preload-common-fixtures
Closed

test: use common.fixtures module in test-preload.js#15975
lzcabrera wants to merge 1 commit into
nodejs:masterfrom
lzcabrera:test-preload-common-fixtures

Conversation

@lzcabrera

@lzcabrera lzcabrera commented Oct 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • replace common.fixturesDir with usage of the common.fixtures module
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 6, 2017
@mscdex mscdex added the cli Issues and PRs related to the Node.js command-line interface. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
BridgeAR
BridgeAR approved these changes Oct 7, 2017
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@BridgeAR BridgeAR self-assigned this Oct 8, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 8, 2017
@lzcabrera @BridgeAR
test: use common.fixtures module in test-preload
0d38e6d 
PR-URL: nodejs#15975
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Oct 8, 2017

Copy link
Copy Markdown
Member

Landed in 0d38e6d

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !
@BridgeAR BridgeAR closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@lzcabrera @MylesBorins
test: use common.fixtures module in test-preload
75ab6c0 
PR-URL: #15975
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@lzcabrera @addaleax
test: use common.fixtures module in test-preload
6a04198 
PR-URL: nodejs/node#15975
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@lzcabrera @MylesBorins
test: use common.fixtures module in test-preload
f903503 
PR-URL: #15975
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@lzcabrera @MylesBorins
test: use common.fixtures module in test-preload
6728a40 
PR-URL: #15975
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@lzcabrera @MylesBorins
test: use common.fixtures module in test-preload
683c5fa 
PR-URL: #15975
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issues and PRs related to the Node.js command-line interface. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to Node.js core tests and test infrastructure.

6 participants

@lzcabrera @BridgeAR @mscdex @MylesBorins @Trott @nodejs-github-bot