Skip to content

worker: keep stdio after exit - #26017

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-stdio-keep
Closed

worker: keep stdio after exit#26017
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-stdio-keep

Conversation

@addaleax

@addaleax addaleax commented Feb 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

This addresses review comments from #25871.

Refs: #25871

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax
worker: keep stdio after exit
ac84d44 
This addresses review comments from
nodejs#25871.

Refs: nodejs#25871
@nodejs-github-bot

nodejs-github-bot commented Feb 9, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2554/pipeline
@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to the worker_threads module and Worker API. label Feb 9, 2019
@addaleax addaleax mentioned this pull request Feb 9, 2019
Closed
@addaleax

addaleax commented Feb 9, 2019

Copy link
Copy Markdown
Member Author

/cc @nodejs/workers @sam-github

CI: https://ci.nodejs.org/job/node-test-pull-request/20692/
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 9, 2019
@addaleax

addaleax commented Feb 11, 2019

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20734/
@addaleax

addaleax commented Feb 12, 2019

Copy link
Copy Markdown
Member Author

Landed in 9e84a26
@addaleax addaleax closed this Feb 12, 2019
@addaleax
addaleax deleted the worker-stdio-keep branch February 12, 2019 00:17
addaleax added a commit that referenced this pull request Feb 12, 2019
@addaleax
worker: keep stdio after exit
9e84a26 
This addresses review comments from
#25871.

Refs: #25871

PR-URL: #26017
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Feb 13, 2019
@addaleax
worker: keep stdio after exit
23868ba 
This addresses review comments from
#25871.

Refs: #25871

PR-URL: #26017
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. worker Issues and PRs related to the worker_threads module and Worker API.

5 participants

@addaleax @nodejs-github-bot @benjamingr @lpinca @cjihrig