Skip to content

build: avoid building V8 snapshot if --without-snapshot - #28467

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:really-no-snapshot
Closed

build: avoid building V8 snapshot if --without-snapshot#28467
targos wants to merge 1 commit into
nodejs:masterfrom
targos:really-no-snapshot

Conversation

@targos

@targos targos commented Jun 28, 2019

Copy link
Copy Markdown
Member
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Jun 28, 2019
@targos targos mentioned this pull request Jun 28, 2019
Closed
@devsnek

devsnek commented Jun 28, 2019

Copy link
Copy Markdown
Member

cc @joyeecheung
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24146/
joyeecheung
joyeecheung approved these changes Jun 28, 2019
View reviewed changes

@joyeecheung joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit for the commit message: “avoid building the default v8 snapshot...” for clarity (or maybe not, but when I saw the title I thought this was to make —without-snapshot imply —without-node-snapshot)
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24156/
@refack

refack commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

Refs: #27838 (comment)
/CC @hashseed is it worth it to fight for "no snapshot"?
refack
refack reviewed Jun 28, 2019
View reviewed changes
Comment thread common.gypi Outdated

@refack refack Jun 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we de-dup this a little bit?

    ['v8_use_snapshot==1', {
      'v8_lib_name': 'snapshot',
    }, {
      'v8_lib_name': 'nosnapshot',
    }],
    ['GENERATOR == "ninja"', {
      'obj_dir': '<(PRODUCT_DIR)/obj',
      'v8_base': '<(PRODUCT_DIR)/obj/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
    }, {
      'obj_dir%': '<(PRODUCT_DIR)/obj.target',
      'v8_base': '<(PRODUCT_DIR)/obj.target/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
    }],
    ['OS == "win"', {
      'obj_dir': '<(PRODUCT_DIR)/obj',
      'v8_base': '<(PRODUCT_DIR)/lib/libv8_<(v8_lib_name).a',
    }],
    ['OS == "mac"', {
      'obj_dir%': '<(PRODUCT_DIR)/obj.target',
      'v8_base': '<(PRODUCT_DIR)/libv8_<(v8_lib_name).a',
    }],

@targos targos Jul 1, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack:

gyp: Undefined variable v8_lib_name in /home/mzasso/git/nodejs/node/node.gyp while trying to load /home/mzasso/git/nodejs/node/node.gyp
@hashseed

hashseed commented Jun 29, 2019

Copy link
Copy Markdown
Member

Fwiw we want to remove no snapshot builds from V8 by the end of this year. We are working on the blockers of that right now. Reason is that it now takes unreasonable amount of time to run without snapshot, and also doesn't match what we ship.
@targos

targos commented Jun 29, 2019

Copy link
Copy Markdown
Member Author

That's good to know. We should probably remove or at least deprecate nosnapshot support in v13 then.
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24239/
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 4, 2019
@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24310/
@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24314/
@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24319/
@targos

targos commented Jul 6, 2019

Copy link
Copy Markdown
Member Author

The same tests failed three times in a row. It seems unlikely to be a flake, but they didn't fail in previous runs. I don't know what to do now...
@addaleax

addaleax commented Jul 6, 2019

Copy link
Copy Markdown
Member
  • 'CERT_HAS_EXPIRED'
  • 'DEPTH_ZERO_SELF_SIGNED_CERT'

Sounds like maybe an issue with the time config for the CI machine? /cc @nodejs/build-infra
@targos
build: do not always build the default V8 snapshot
995ecd3 
It should be skipped if Node.js is built with the --without-snapshot
configure flag.
@targos
targos force-pushed the really-no-snapshot branch from b3dbe01 to 995ecd3 Compare July 12, 2019 07:50
@targos

targos commented Jul 12, 2019

Copy link
Copy Markdown
Member Author

I rebased on master and reworded the commit message. Maybe CI will pass now.
@nodejs-github-bot

nodejs-github-bot commented Jul 12, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24399/
@targos

targos commented Jul 12, 2019

Copy link
Copy Markdown
Member Author

Landed in a8ed416
@targos targos closed this Jul 12, 2019
@targos
targos deleted the really-no-snapshot branch July 12, 2019 14:32
targos added a commit that referenced this pull request Jul 12, 2019
@targos
build: do not always build the default V8 snapshot
a8ed416 
It should be skipped if Node.js is built with the --without-snapshot
configure flag.

PR-URL: #28467
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 20, 2019
@targos
build: do not always build the default V8 snapshot
171c8f4 
It should be skipped if Node.js is built with the --without-snapshot
configure flag.

PR-URL: #28467
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure.