path: replace var with let in lib/path.js - #30260
Closed
peze wants to merge 1 commit into
Closed
Conversation
gireeshpunathil
added
the
code-and-learn
Collaborator
BridgeAR
approved these changes
Nov 5, 2019
devnexen
approved these changes
Nov 5, 2019
trivikr
approved these changes
Nov 5, 2019
Member
There was a problem hiding this comment.
nit: this let i can be removef and moved to lines 691 and 731 respectively
Line 691:
for (let i = path.length - 1; i >= start; --i) {Line 731:
for (let i = path.length - 1; i >= start; --i) {
Contributor
Author
There was a problem hiding this comment.
good idea ,i've fixed it;
addaleax
approved these changes
Nov 5, 2019
gireeshpunathil
approved these changes
Nov 6, 2019
Collaborator
gireeshpunathil
added
the
author ready
ChALkeR
approved these changes
Nov 6, 2019
Member
|
Landed in 896b75a |
Trott
pushed a commit
that referenced
this pull request
Nov 9, 2019
PR-URL: #30260 Refs: nodejs/code-and-learn#97 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30260 Refs: nodejs/code-and-learn#97 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30260 Refs: nodejs/code-and-learn#97 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30260 Refs: nodejs/code-and-learn#97 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path: replace var with let in lib/path.js
Refs: nodejs/code-and-learn#97
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes