test: changed var to const in test-repl-unexpected-token-recoverable.js - #30434
Closed
bassgeta wants to merge 1 commit into
Closed
test: changed var to const in test-repl-unexpected-token-recoverable.js#30434bassgeta wants to merge 1 commit into
bassgeta wants to merge 1 commit into
Conversation
Changed outdated var to const in the test file mentioned above.
nodejs-github-bot
added
the
test
targos
approved these changes
Nov 12, 2019
cjihrig
approved these changes
Nov 12, 2019
gireeshpunathil
added
the
code-and-learn
trivikr
approved these changes
Nov 13, 2019
BridgeAR
approved these changes
Nov 13, 2019
BridgeAR
added
the
author ready
Collaborator
jasnell
approved these changes
Nov 14, 2019
gireeshpunathil
approved these changes
Nov 17, 2019
Collaborator
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 17, 2019
Changed outdated var to const in the test file repl-unexpected-token-recoverable.js PR-URL: #30434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
landed in dcbb2ec, thanks for the contribution! |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 19, 2019
Changed outdated var to const in the test file repl-unexpected-token-recoverable.js PR-URL: #30434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Changed outdated var to const in the test file repl-unexpected-token-recoverable.js PR-URL: #30434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Changed outdated var to const in the test file repl-unexpected-token-recoverable.js PR-URL: #30434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed outdated var to const in the test file mentioned above.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes